feat(stdlib): Ipc.affine — MessageChannel + structuredClone (bindings #9)#506
Merged
Conversation
) New stdlib module covering host↔guest message-passing — the Tier-1 #9 binding consumers (idaptik-ums Gossamer IPC for level I/O) have been waiting on. stdlib/Ipc.affine (+105 lines): 2 extern types + 9 extern fns. | Surface | Externs | |---|---| | Channel | extern type MessageChannel, MessagePort; messageChannelNew; messageChannelPort1/2 | | Port | messagePortPostMessage; messagePortOnMessage; messagePortStart; messagePortClose | | Cross-context | targetPostMessage (Worker / iframe.contentWindow / self-from-worker) | | Deep-clone | structuredCloneValue | No consumer init required — `MessageChannel`, `MessagePort`, and `structuredClone` are standard web-platform globals in Deno, Node 16+, browsers, and Web Workers. Generated code emits direct references to `MessageChannel` / `structuredClone` — there is no host indirection table. lib/codegen_deno.ml (+23 lines): 9 `__as_*` prelude helpers + 9 `deno_builtins` dispatch entries adjacent to the pixiSound block. tests/codegen-deno/ipc_smoke.{affine,harness.mjs} (+98 lines combined): new smoke fixture exercises: - A port-pair postMessage round-trip with handler identity preserved across `on` - The standalone `messagePortClose` lifecycle - The generic `targetPostMessage` shape via a stub target object - A `structuredCloneValue` deep-copy with reference-distinctness assertions across nested arrays + objects The fixture documents (in the source) why the host keeps the channel handle alive across the drain — Node's worker-threads-backed `MessagePort` GCs the moment its last reference drops — and why a single setImmediate isn't enough for delivery (the empirical delivery window needs a real `setTimeout`). docs/bindings-roadmap.adoc row #9 status promoted `○ → ◑`; deferred items (transfer-list, BroadcastChannel, typed MessageEvent accessors, Worker constructors — Tier 3 #25) listed. Refs #446 — Tier 1 #9.
809a7f2 to
3863bf1
Compare
6 tasks
hyperpolymath
added a commit
that referenced
this pull request
May 31, 2026
…#510) ## Summary Ships the Canvas 2D half of Tier-1 #8 of #446. This is the surface `idaptik-ums` (App.res: 1178 LoC of DOM + canvas) and every non-Pixi UI in the estate has been waiting for; WebGL / WebGL2 / WebGPU stays at `○` until a consumer surfaces a concrete need. ## What lands `stdlib/Canvas.affine` (+170 lines, new module): 1 extern type (`Ctx2D`) + 26 extern fns covering the full idaptik-ums-relevant Canvas 2D surface: | Surface | Externs | |---|---| | Context acquisition | `canvasGetContext2D` | | Styles | `canvasFillStyle` / `StrokeStyle` / `LineWidth` / `GlobalAlpha` | | Rectangles | `canvasFillRect` / `StrokeRect` / `ClearRect` | | Paths | `canvasBeginPath` / `ClosePath` / `MoveTo` / `LineTo` / `Arc` / `Fill` / `Stroke` | | Transform stack | `canvasSave` / `Restore` / `Translate` / `Rotate` / `Scale` | | Text | `canvasFont` / `TextAlign` / `TextBaseline` / `FillText` / `StrokeText` / `MeasureText` | | Images | `canvasDrawImage` / `canvasDrawImageScaled` | `lib/codegen_deno.ml` (+58 lines): 26 `__as_canvas*` prelude helpers + 26 dispatch entries adjacent to the Ipc block. `tests/codegen-deno/canvas_smoke.{affine,harness.mjs}` (+160 lines combined): 5 distinct smoke functions exercise every shipped extern. The `MockCtx2D` records every method call as a typed-op tuple so the test asserts call order + arguments, not just side-effects. The `canvasMeasureText` round-trip exercises the `Json`-return shape (the `TextMetrics`-shaped object). `docs/bindings-roadmap.adoc` row #8 status promoted `○ → ◑`; deferred items captured (WebGL, gradients/patterns, ImageData, curve primitives, compositing/clip). ## Design notes **Why is `HTMLCanvasElement` not its own extern type?** The canvas-creation entry point is host-dependent — browser `document.createElement("canvas")` vs idaptik's pre-existing DOM tree vs jsdom-under-Deno. Treating the canvas as opaque `Json` defers the typed wrapper to the natural follow-up once `affinescript-dom` lands runtime support (currently blocked on the wasm-codegen `for-in` / `while` gap, issue #255). **Why fix `arc` counter-clockwise to `false`?** The 6-arg shape (`ccw` boolean) would force every call site to pass a literal `false`. The 5-arg shape covers the overwhelming majority of consumers; a typed wrapper with the `ccw` flag is a follow-up if a consumer surfaces the need. **Why two separate `drawImage` externs instead of one with optional args?** AffineScript doesn't have JS-style variadic functions; making `w` and `h` `Option<Float>` would force every natural-size call to thread `None`s. The two-extern split keeps each call site simple. **Why open-string `eventMode` / `textAlign` / `textBaseline`?** Same rationale as the PixiJS expansion (#502) — Pixi 8's `eventMode` and Canvas's text-alignment values are open enumerations, and a sum-type binding would either freeze the set or require tagged-variant codegen that doesn't exist on the Deno-ESM backend yet (deferred to json.affine v0.3). Consistency with existing patterns. ## Test plan - [x] `dune build bin/main.exe` — clean (only the expected parser warnings) - [x] `dune runtest --force` — 356 tests pass (was 354 pre-PR; +2 from new Canvas + Ipc modules' AOT smoke) - [x] `tools/run_codegen_deno_tests.sh` — all 19 harnesses including the new `canvas_smoke.harness.mjs` OK - [ ] CI build job - [ ] CI `tools/run_codegen_deno_tests.sh` job - [ ] CI governance + Hypatia (6 baselines per repo CLAUDE.md may be red — pre-existing on main, not regressions) ## Refs - Umbrella: #446 (Tier 1 — idaptik blockers) - Tier-1 sub-issue: #450 - Row updated: `docs/bindings-roadmap.adoc` row #8 - Pattern siblings shipped this session: #502 (PixiJS Container expansion), #506 (Ipc.affine) - Adjacent / future: `affinescript-dom` (gated on #255), WebGL/WebGPU (Tier 3 axis, not surfaced as need yet) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
🔍 Hypatia Security ScanFindings: 83 issues detected
View findings[
{
"reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action ons/checkout@v6\n needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action land/setup-deno@v2\n needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in affine-vscode-publish.yml",
"type": "missing_timeout_minutes",
"file": "affine-vscode-publish.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships the first concrete surface for Tier-1 #9 of #446 — IPC / structuredClone for host↔guest message passing. This is the binding
idaptik-umsGossamer IPC for level I/O depends on, and the pattern any embedded-engine binding in the estate needs.What lands
stdlib/Ipc.affine(+105 lines, new module): 2 extern types + 9 extern fns covering MessageChannel construction, port handoff, post + onmessage, start/close lifecycle, generictargetPostMessage, andstructuredCloneValue.MessageChannel/MessagePortopaque types;messageChannelNew/messageChannelPort1/messageChannelPort2messagePortPostMessage/messagePortOnMessage/messagePortStart/messagePortClosetargetPostMessage(Worker / iframe.contentWindow / self-from-worker)structuredCloneValuelib/codegen_deno.ml(+23 lines): 9__as_*prelude helpers + 9 dispatch entries adjacent to the pixiSound block. No consumer init —MessageChannel/MessagePort/structuredCloneare standard web-platform globals.tests/codegen-deno/ipc_smoke.{affine,harness.mjs}(+98 lines combined): port-pair postMessage round-trip with handler-identity preservation, standalone close lifecycle, target-post stub, and structuredClone deep-copy with reference-distinctness assertions across nested arrays + objects.docs/bindings-roadmap.adocrow #9 promoted○ → ◑; deferred items listed.Design notes
Why is
MessagePortan opaqueextern typeinstead of a record/tagged-union? Same reasonWasmExportsandWasmValue(#467) are opaque — the Deno-ESM backend doesn't yet have tagged-variant codegen (deferred to json.affine v0.3), and a realMessagePortcarries internal worker-thread state that isn't usefully observable from AffineScript anyway. The handler observes theMessageEventas opaqueJsonand readsevent.datavia the existing Json accessors. A typedMessageEventextern-type with dedicated accessor externs is the natural follow-up axis, captured in the roadmap deferred-items list.Why is the host responsible for closing the ports? Inline
close()calls insmokeChannelFlowwould race the microtask-async delivery — MessagePort drops queued messages on close. The fixture surfaces this as a documented authoring pattern (it lives in a top-of-file comment) so anyone writing IPC code with this binding doesn't get bitten.Why
setTimeout(50)in the harness instead ofsetImmediate/microtask flush? Empirically verified — Node 20'sworker_threads-backedMessageChannelbatches delivery beyond a single setImmediate tick. The comment in the harness records the test that surfaced it (a standalonenoderepl reproducer with the same shape).Why no
transferlist yet? Owner directive at #455 (Option-B kickoff scope) — ship the generic surface, layer typed-and-richer variants as follow-ups once usage patterns crystallise. Same pattern asWasmValue— opaque tagged scalar first, typed wrappers next.Test plan
dune build bin/main.exe— clean (only the expected parser warnings)dune runtest— 354 tests passtools/run_codegen_deno_tests.sh— all 18 harnesses including the newipc_smoke.harness.mjsOKtools/run_codegen_deno_tests.shjobRefs
docs/bindings-roadmap.adocrow ci: Bump actions/checkout from 4.1.1 to 6.0.2 #9wasm_export_callOption-B), Roadmap tracking + Zig-FFI doc (#19) + hex/base64 encoding (#25) + Int-division codegen fix (#478) #474 (Zig-FFI patterns doc), feat(stdlib): PixiJS 8.x Container transform-and-event surface (bindings #1) #502 (PixiJS 8.x Container)Workerconstructors would consume this surface🤖 Generated with Claude Code